Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update activity_main layout #14

Merged
merged 5 commits into from Sep 29, 2021
Merged

Conversation

HACore
Copy link
Contributor

@HACore HACore commented Sep 27, 2021

메인 화면 마크업 작업 완료했습니다.

레이아웃에서 사용되는 색상은 colors.xml에 정의해두었고 텍스트도 strings.xml에 정의해두었으니 버튼의 문구가 변하는 상황 등에서 가져다 사용하시면 됩니다.

ProgressBar의 경우 기본 디자인을 사용했습니다.
image
다른 디자인이 필요하다 생각되시면 말씀주세요!

+ codeowners 파일에서 주석 오타 수정했습니다.

@HACore HACore requested a review from a team September 27, 2021 21:20
@HACore HACore linked an issue Sep 27, 2021 that may be closed by this pull request
Copy link
Contributor

@kmsaidev kmsaidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘하셨네요!! 감사합니다👍👍

@psh2849
Copy link
Contributor

psh2849 commented Sep 28, 2021

확인했습니다!
엄청 잘 만들어주셨네요! 감사합니다 👍👍👍👍

@jopopcorn jopopcorn self-requested a review September 28, 2021 07:34
Copy link
Member

@jopopcorn jopopcorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘하셨네요!! 색상이랑 스트링 리소스 따로 저장해주신 것도 센스 넘치십니다 ㅎㅎ 고생하셨어요!!

@jopopcorn jopopcorn merged commit 4d88084 into euphony-io:master Sep 29, 2021
@HACore HACore self-assigned this Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

메인 화면 마크업
4 participants