Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More consistent naming #40

Open
mancellin opened this issue Apr 26, 2024 · 0 comments
Open

More consistent naming #40

mancellin opened this issue Apr 26, 2024 · 0 comments

Comments

@mancellin
Copy link
Member

To avoid giving different names to the same thing or the same name to different things

model = ModelEvaluation(estimator=ms.best_model_)

could be changed to something like

model_evaluation = ModelEvaluation(model=ms.best_model_)

Also for consistency, one might consider having either

  • ModelSelection and ModelEvaluation
  • or ModelSelector and ModelEvaluator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mancellin