Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[irteus/irtgeo.l] move :move-coords method to coordinates class #486

Merged
merged 1 commit into from Jul 17, 2018

Conversation

mmurooka
Copy link
Contributor

The useful method :move-coords is defined in cascaded-coords class although the method does not depend on cascaded features. How about move this method from cascaded-coords to coordinate?
(This is just for utility so if not so many positive reaction, it's OK to close.)

Now :move-coords method is not defined in coordinate class, so this PR does not change bihavior of current working code.

13.irteusgl$ (assoc :move-coords (send coordinates :methods))
nil
14.irteusgl$ (assoc :move-coords (send cascaded-coords :methods))
(:move-coords #<compiled-code #X5d92d88>)

@k-okada
Copy link
Member

k-okada commented Feb 28, 2018

@snozawa added this method, any comments? mmurooka@ce331bb

@mmurooka
Copy link
Contributor Author

#471 was discarded in automatic rebase, so I fixed manually.

@k-okada k-okada merged commit b46fee1 into euslisp:master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants