Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No way to remove images? #15

Closed
theianjohnson opened this issue Apr 10, 2017 · 3 comments
Closed

No way to remove images? #15

theianjohnson opened this issue Apr 10, 2017 · 3 comments

Comments

@theianjohnson
Copy link

Here's my use case -

LinkedIn only seems to grab the first og:image
I set a default "catch all" image in Controller.php
I set more specific images in controllers that extend Controller.php
I output images with {!! Meta::tag('image') !!}

Is there any way to -

Unset a previously set image? Or override an image? Or reverse the order of the images?
@eusonlito
Copy link
Owner

eusonlito commented Apr 10, 2017 •
edited

Avoid to set a default image into constructor.

As example show:

    <head>
        ...

        {{-- Print custom section images and a default image if not set --}}
        {!! Meta::tag('image', asset('images/default-logo.png')) !!}
    </head>

@theianjohnson
Copy link
Author

That does work, but being able to set a default image then override it seems like a pretty common use case

No worries if it's not something you're looking to add, I'll take a look around and see if any other Laravel libraries implement it like this, cheers!

@eusonlito
Copy link
Owner

Please, upgrade to last release v3.1.1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eusonlito @theianjohnson