Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_modes absent from API spec? #23

Closed
G33kDude opened this issue Dec 8, 2014 · 4 comments
Closed

run_modes absent from API spec? #23

G33kDude opened this issue Dec 8, 2014 · 4 comments

Comments

@G33kDude
Copy link
Contributor

G33kDude commented Dec 8, 2014

It seems really inconsistent which of the "mode" attributes get a "modes". Motors get stop_modes, but no run_modes, regulation_modes or position_modes, and Sensors get both mode and modes.

Is there a reason for this? Is it seen that stop_modes is necessary but other "modes" aren't?

@WasabiFan
Copy link
Member

Any omissions were not intentional; were those added recently? Either way, I'll add those properties (and make sure that there aren't any more that I missed) tonight. Thanks for the tip!

@dlech
Copy link
Member

dlech commented Dec 8, 2014

You can find the kernel changelog here.

Applicable changes to this repo are:

linux-source-3.16.1-7-ev3dev (1) testing; urgency=medium
* Add new command and commands attributes to msensor class. This replaces
modes in some cases.
* [rhemel]: Rename dc-motor duty_cycle attribute to duty_cycle_sp and add new
duty_cycle attribute that returns current duty cycle.
linux-source-3.16.1-6-ev3dev (1) testing; urgency=medium
* tacho-motor class device are now named `motor<N>` instead of
`tacho-motor<N>`.
linux-source-3.16.1-5-ev3dev (1) testing; urgency=medium
* [rhempel] Fixed a number of tacho motor bugs

I think the new tacho-motor attributes were lumped into this last one. ev3dev/ev3-kernel@1a43723

And of course, there are the driver doc pages as well. tacho-motor, servo-motor, dc-motor, msensor.

@WasabiFan
Copy link
Member

@dlech I'll read through the changelog to make sure that there isn't anything else that I missed to include in my updates tonight.

@WasabiFan
Copy link
Member

@G33kDude Thanks for the tip on those missing properties. I added them to our JSON spec, so they should show up for our next release once we get the libraries working off of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants