Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get publish script working on Windows #146

Open
WasabiFan opened this issue Apr 28, 2016 · 3 comments
Open

Get publish script working on Windows #146

WasabiFan opened this issue Apr 28, 2016 · 3 comments

Comments

@WasabiFan
Copy link
Member

Currently, the publish.rb script doesn't work on Windows. As far as I can tell, this is just because of the eval()-ed grep call. If we can find an alternative way in native Ruby, that would make it much easier to publish from Windows

@dlech
Copy link
Member

dlech commented Apr 28, 2016

Does it work in a git bash shell?

There is no guarantee that git will be in the PATH otherwise.

@WasabiFan
Copy link
Member Author

Whoops, thought I had followed up here, but apparently not.

Yes, it works (ish) in Git Bash. It still throws some errors because of a permissions issue when deleting the temp directory that it creates. I want to fix that, but in addition it would be great to actually have it run natively instead of having to use that bash shell (which is a pain -- it's much harder to get to the directory you want in Git Bash than it is in a normal prompt). If that doesn't happen, at a minimum we'll need to document usage of the shell and execution of the publish script so that people can publish their changes for preview (and update the "publishing a project" tutorial in the process).

There is no guarantee that git will be in the PATH otherwise.

There isn't on any other system either; what makes Windows different?

@dlech
Copy link
Member

dlech commented May 21, 2016

On Linux, it is pretty much guaranteed to be in the PATH (unless you are doing something highly unusual). On OS X, if you are using homebrew - which you probably are if you installed rbenv - which you probably did because jekyll won't work with the system version of ruby, it will be in the PATH.

You could also make a power shell script for Windows that does the same thing if that is easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants