Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types #34

Closed
11 of 12 tasks
evaera opened this issue Sep 29, 2018 · 2 comments
Closed
11 of 12 tasks

Add types #34

evaera opened this issue Sep 29, 2018 · 2 comments
Labels
type:enhancement New feature or request

Comments

@evaera
Copy link
Owner

evaera commented Sep 29, 2018

  • brickColor, brickColors https://gist.github.com/TripleFrequency/e43fe44d50d596634894ee236fdac71e
  • duration, durations
  • brickColor3, brickColor3s - resolves into a Color3, but selected by brickColor name
  • teamColor, teamColors - resolves into BrickColor matching by team, uses that team's color
  • hexColor3, hexColor3s - resolve hex into Color3
  • color3, color3s (delineate by comma or spaces, checking comma first) - Color3
  • vector3, vector3s (delineate by comma or spaces, checking comma first) - Vector3
  • time
  • integers
  • strings
  • numbers
  • booleans
@evaera evaera added the type:enhancement New feature or request label Sep 29, 2018
@evaera evaera added this to the 1.1 milestone Sep 29, 2018
@TripleFrequency
Copy link
Contributor

Perhaps there could also be some types for time:

  • duration - formatted like 4d, 1h, 1w2d1h, etc.
  • time - formatted roughly like ISO 8601: 2018-09-29T13:00:00.000Z

The time type is clearly very complex for regular users, but perhaps there could be other formats for it, or you could use defaults. So, 2018-09-29 or 09/29/18 would work.

Both of these types should equate to durations in seconds, or time in epoch seconds (since Lua uses seconds instead of milliseconds).

@Validark
Copy link
Contributor

I can write a time type.

@evaera evaera added the help wanted Contributions welcome label Sep 30, 2018
@evaera evaera removed the help wanted Contributions welcome label Jan 11, 2019
@evaera evaera closed this as completed Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants