Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queued callbacks do not begin on new threads #31

Closed
ArthurZC23 opened this issue Jul 10, 2020 · 2 comments
Closed

Queued callbacks do not begin on new threads #31

ArthurZC23 opened this issue Jul 10, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@ArthurZC23
Copy link

ArthurZC23 commented Jul 10, 2020

Description of the bug: The following error is thrown when yielding in the chain andThen after the resolution of Promise.delay: Promise:726: attempt to index nil with 'next' .
Frequency of the error (in the this artificial example posted below): 100%

Reproduction steps

Run the following server script:

local ServerStorage = game:GetService("ServerStorage")

local Promise = require(ServerStorage.src.Promise)


Promise.delay(5):andThen(function ()
    wait(2)
end)

@evaera evaera added the bug Something isn't working label Jul 11, 2020
@evaera
Copy link
Owner

evaera commented Jul 11, 2020

Thanks for the report, I discovered a previously unknown bug in the Promise library due to this!

@evaera evaera changed the title delay static method don't support yield Queued callbacks do not begin on new threads Jul 11, 2020
@evaera evaera closed this as completed in 13ae48a Jul 11, 2020
@ArthurZC23
Copy link
Author

Yeah, I read the commit. I'm glad you found out and fix it so fast!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants