-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promise.defer
should use task.defer
#88
Comments
Why? |
I think |
Here's a few reasons:
One thing to consider:
P.s. task.defer(coroutine.running())
coroutine.yield() |
Currently,
Promise.defer
usesRunService.Heartbeat
, which should be replaced withtask.defer
instead. The current implementation ofPromise.defer
results in the Promise being resumed in the next frame, rather than the next invocation point.The text was updated successfully, but these errors were encountered: