Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when trying dep without namespace #27

Open
jeroenvandijk opened this issue Oct 31, 2023 · 2 comments
Open

Error when trying dep without namespace #27

jeroenvandijk opened this issue Oct 31, 2023 · 2 comments

Comments

@jeroenvandijk
Copy link

I tried deps-try amazonica "0.3.165" which results in an error Could not find path '***/amazonica'

I should have tried deps-try amazonica/amazonica "0.3.165" instead, and then things work as expected.

This might not be obvious for new users. I also had to think for a bit. And this would also not be obvious by reading the README of Amazonica where it is still [amazonica "0.3.165"].

When there is no namespace maybe if the directory doesn't exist (in this case amazonica), deps-try could try to resolve it as a dependency?

(*) tested with version deps-try-dev v0.8.0

@eval
Copy link
Owner

eval commented Nov 1, 2023

I was just thinking about this recently and was wondering if this is an expectation, so thanks for bringing this up 👍🏻

I think it's unwanted to make deps-try foo automatically work as deps-try foo/foo as this would allow for continuing not using a group-id. Also clashing with a planned command-style CLI, e.g. deps-try recipes [ls|help].

I think an error with a did-you-mean-message would be apt - which could be implemented as a maven/clojars-search and so would also work for someone trying deps-try malli.

@jeroenvandijk
Copy link
Author

Ah cool. Yeah I like your proposal more. I think it is less confusing and more consistent. And like what you said, it would indeed also help promote using the group-id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants