Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json cat gif example broken #135

Closed
niccolox opened this issue May 1, 2019 · 2 comments
Closed

json cat gif example broken #135

niccolox opened this issue May 1, 2019 · 2 comments

Comments

@niccolox
Copy link

niccolox commented May 1, 2019

hi

the json example is broken

  1. the api key is rate limited
  2. the gliphy api has changed structure, the image urls are nested deeper

I'll try to post a fix, but heads up there is a docs example issue

thanks

@niccolox niccolox changed the title json cat git example broken json cat gif example broken May 1, 2019
@niccolox
Copy link
Author

niccolox commented May 1, 2019

cancel that, all I needed was a new key

@niccolox niccolox closed this as completed May 1, 2019
@dgollahon
Copy link

When I tried to do the tutorial, I had the same problem. IIRC, it was not obvious from the error message in the example this was the problem.

I think this issue should still be open and maybe the guide can be updated to advise the user that they will need an API key, get the gifs from another source where this won't be a problem, improve the error message so it tells you the full error and what you can do about it, or possibly have the key automatically refreshed periodically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants