Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use indexedMap #87

Closed
iqualfragile opened this issue Jun 28, 2016 · 1 comment
Closed

use indexedMap #87

iqualfragile opened this issue Jun 28, 2016 · 1 comment

Comments

@iqualfragile
Copy link

instead of redundantly saving the index of an element, just use indexedMap, it simplifies the code by removing some deconstruction.
of cause this would remove the uniqueness of the keys.

@evancz
Copy link
Owner

evancz commented Jun 29, 2016

It's important that the keys are unique. If a change needs to happen to item 4, but item 4 is removed before it is applied, we do not want to accidentally apply it to item 5.

@evancz evancz closed this as completed Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants