-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto compile #16
Auto compile #16
Conversation
- Add trimmed down codemirror 3.0 package - Move elm specific changes from CodeMirror 2.13 - Update editor css according to upgrade guide - Make compile script executable under unix/linux - Git ignore ghc output and Server executable
Very cool! I am going through the changes now. I guess the only things I have questions about are the cosmetic changes. Like you uncommented some code in the Elm syntax highlighting file, but that stuff is somewhat Haskell specific. It appears that the current line marker is out (just looking at the code). What is the reasoning here? Is this generally personal preference? Just curious :) The important variable is the timeout on auto-compile and it looks like I can tweak that very easily. |
Looks great! Nice work! |
Thanks! With regards to the syntax highlighting. I took the updated haskell highlighter from codemirror 3.0 and tried to merge in your changes, but must have missed the commented-out section. Thanks for spotting that, you can re-disable this part if you want. Same goes for the current line marker - sorry about that |
And the change in the editor css is because Codemirror has changed how they pickup the height of the editor element, see http://codemirror.net/doc/upgrade_v3.html |
Thanks again! This change kicked me into cleaning up the editor quite a bit. I actually ended up enabling a bunch of different color schemes and did some trickery with cookies to save the editor settings between sessions. |
You are welcome, and yes I already noticed your changes - it looks really I am currently working on a feature to enable inline documentation lookup. On Tue, Jan 15, 2013 at 10:21 PM, Evan Czaplicki
|
Thanks :D Someone was suggesting exactly this feature just yesterday, so I am doubly excited to see it! |
Hi,
really enjoy experimenting with Elm, and I like your learn-by-example / no-install approach (although installing Elm locally was straight forward as well).
While working with the online examples and trying to tweak them I found myself going through the documentation several times to try and find what I was looking for. So I want to see if some of CodeMirrors features can be used to make it even easier to experiment with and learn Elm.
This is a small step which includes two features:
The pull request also updates CodeMirror to version 3.0, as I think it is best to work from the latest release when venturing to other things, like inline documentation (which I wanted to take a stab at).