Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommonJS module loader does not work #13

Closed
wolfika opened this issue Sep 19, 2016 · 1 comment
Closed

CommonJS module loader does not work #13

wolfika opened this issue Sep 19, 2016 · 1 comment

Comments

@wolfika
Copy link

wolfika commented Sep 19, 2016

The global object in a browser window is window, which can also be referenced using this, like I said in my previous comment in #6 when writing a tip about how to implement this library as a universal module. However, in the module factory block, the global object is referenced by window, which, when loaded as a CommonJS module is undefined. This causes an error, and prevents the user from using this library.

Attaching screenshot:
image

FYI @EvandroLG

@EvandroLG
Copy link
Owner

hi @wolfika I think it just happens because you're runing pageAccelerator in a node envirment. In a web browser, it wouldn't happen, right?

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants