Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in query.rs #8

Closed
STPR opened this issue Apr 24, 2023 · 2 comments 路 Fixed by #9
Closed

Error in query.rs #8

STPR opened this issue Apr 24, 2023 · 2 comments 路 Fixed by #9

Comments

@STPR
Copy link

STPR commented Apr 24, 2023 •
edited

Hello,
Thanks for this library 馃憤

There's an error in the query.rs file:

openweathermap/client/src/query.rs

Line 20 in f5fe871

vec![("lat", self.lat.to_string()), ("lon", self.lat.to_string())]

Must be:

vec![("lat", self.lat.to_string()), ("lon", self.lon.to_string())]
@evaneaston
Copy link
Owner

You are right. I clearly don't rely on that variant, or have a test.

@evaneaston evaneaston mentioned this issue Apr 25, 2023
Merged
@evaneaston
Copy link
Owner

@STPR thanks for the bug report. I've published a fix for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug/Issue#8 evaneaston/openweathermap
2 participants
@evaneaston @STPR