Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change instances of 'raise ValueError()' to 'raise NotImplementedError()' #28

Closed
nstair opened this issue Oct 9, 2019 · 0 comments
Closed

Change instances of 'raise ValueError()' to 'raise NotImplementedError()' #28

nstair opened this issue Oct 9, 2019 · 0 comments

Comments

@nstair
Copy link
Contributor

nstair commented Oct 9, 2019

I have been raising value errors to prevent access to portions of the code which are not implemented or tested yet. the NotImplementedError is more appropriate.
@nstair nstair closed this as completed Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nstair