Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hooks to check against null when no hook is specified #51

Open
evanplaice opened this issue Jan 13, 2016 · 1 comment
Open

Change hooks to check against null when no hook is specified #51

evanplaice opened this issue Jan 13, 2016 · 1 comment
Labels
Milestone

Comments

@evanplaice
Copy link
Owner

Currently, false is used as the value to indicate that a hook hasn't been set.

This can and will cause conflicts with user-defined hooks that use false as a return value for their particular use case.

This is an API breaking change so it should be included in the next major release.

Ref: #44

@evanplaice evanplaice added this to the 1.0 milestone Jan 13, 2016
@evanplaice
Copy link
Owner Author

This change needs to be implemented because the current implementation will break in rare cases where the value being returned should be false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant