Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project crashed after upgrade esbuild, related to __toModule #1427

Closed
fy0 opened this issue Jul 7, 2021 · 2 comments
Closed

project crashed after upgrade esbuild, related to __toModule #1427

fy0 opened this issue Jul 7, 2021 · 2 comments

Comments

@fy0
Copy link

fy0 commented Jul 7, 2021

Source code:

import { game } from 'csharp';
var puerts = require("csharp");

console.log("xxxxxxx", game.CSharpUtils); // ==============> got undefined
console.log("xxxxxxx", puerts.game.CSharpUtils._io_path_GetDirectoryName);

Old generated code (works - <= 0.8.54):

var __create = Object.create;
var __defProp = Object.defineProperty;
var __getProtoOf = Object.getPrototypeOf;
var __hasOwnProp = Object.prototype.hasOwnProperty;
var __getOwnPropNames = Object.getOwnPropertyNames;
var __getOwnPropDesc = Object.getOwnPropertyDescriptor;
var __markAsModule = (target) => __defProp(target, "__esModule", {value: true});
var __exportStar = (target, module2, desc) => {
  if (module2 && typeof module2 === "object" || typeof module2 === "function") {
    for (let key of __getOwnPropNames(module2))
      if (!__hasOwnProp.call(target, key) && key !== "default")
        __defProp(target, key, {get: () => module2[key], enumerable: !(desc = __getOwnPropDesc(module2, key)) || desc.enumerable});
  }
  return target;
};
var __toModule = (module2) => {
  if (module2 && module2.__esModule)
    return module2;
  return __exportStar(__markAsModule(__defProp(module2 != null ? __create(__getProtoOf(module2)) : {}, "default", {value: module2, enumerable: true})), module2);
};

// src/index.ts
var import_csharp = __toModule(require("csharp"));
var puerts = require("csharp");
console.log("xxxxxxx", import_csharp.game.CSharpUtils);
console.log("xxxxxxx", puerts.game.CSharpUtils._io_path_GetDirectoryName);
//# sourceMappingURL=bundle.js.txt.map

New generated code (latest):

var __create = Object.create;
var __defProp = Object.defineProperty;
var __getOwnPropDesc = Object.getOwnPropertyDescriptor;
var __getOwnPropNames = Object.getOwnPropertyNames;
var __getProtoOf = Object.getPrototypeOf;
var __hasOwnProp = Object.prototype.hasOwnProperty;
var __markAsModule = (target) => __defProp(target, "__esModule", { value: true });
var __reExport = (target, module2, desc) => {
  if (module2 && typeof module2 === "object" || typeof module2 === "function") {
    for (let key of __getOwnPropNames(module2))
      if (!__hasOwnProp.call(target, key) && key !== "default")
        __defProp(target, key, { get: () => module2[key], enumerable: !(desc = __getOwnPropDesc(module2, key)) || desc.enumerable });
  }
  return target;
};
var __toModule = (module2) => {
  return __reExport(__markAsModule(__defProp(module2 != null ? __create(__getProtoOf(module2)) : {}, "default", module2 && module2.__esModule && "default" in module2 ? { get: () => module2.default, enumerable: true } : { value: module2, enumerable: true })), module2);
};

// src/index.ts
var import_csharp = __toModule(require("csharp"));
var puerts = require("csharp");
console.log("xxxxxxx", import_csharp.game.CSharpUtils);
console.log("xxxxxxx", puerts.game.CSharpUtils._io_path_GetDirectoryName);
//# sourceMappingURL=bundle.js.txt.map
@fy0
Copy link
Author

fy0 commented Jul 7, 2021

0.8.54 works, 0.8.55 crashed:

v0.8.54...v0.8.55#diff-dfb217f99ae89452063f7bc651da92476ba387fc6de37495c98096ad67f5ba10

code generated by 0.8.55:

var __create = Object.create;
var __defProp = Object.defineProperty;
var __getProtoOf = Object.getPrototypeOf;
var __hasOwnProp = Object.prototype.hasOwnProperty;
var __getOwnPropNames = Object.getOwnPropertyNames;
var __getOwnPropDesc = Object.getOwnPropertyDescriptor;
var __markAsModule = (target) => __defProp(target, "__esModule", {value: true});
var __exportStar = (target, module2, desc) => {
  if (module2 && typeof module2 === "object" || typeof module2 === "function") {
    for (let key of __getOwnPropNames(module2))
      if (!__hasOwnProp.call(target, key) && key !== "default")
        __defProp(target, key, {get: () => module2[key], enumerable: !(desc = __getOwnPropDesc(module2, key)) || desc.enumerable});
  }
  return target;
};
var __toModule = (module2) => {
  return __exportStar(__markAsModule(__defProp(module2 != null ? __create(__getProtoOf(module2)) : {}, "default", module2 && module2.__esModule && "default" in module2 ? {get: () => module2.default, enumerable: true} : {value: module2, enumerable: true})), module2);
};

// src/index.ts
var import_csharp = __toModule(require("csharp"));
var puerts = require("csharp");
console.log("xxxxxxx", import_csharp.game.CSharpUtils);
console.log("xxxxxxx", puerts.game.CSharpUtils._io_path_GetDirectoryName);
//# sourceMappingURL=bundle.js.txt.map

@evanw
Copy link
Owner

evanw commented Jan 14, 2023

I'm closing this due to age. There is no longer a generated function called __toModule.

@evanw evanw closed this as not planned Won't fix, can't repro, duplicate, stale Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants