Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not handle instantiation expression correctly #2907

Closed
zen0wu opened this issue Feb 9, 2023 · 1 comment
Closed

Does not handle instantiation expression correctly #2907

zen0wu opened this issue Feb 9, 2023 · 1 comment

Comments

@zen0wu
Copy link

zen0wu commented Feb 9, 2023

This code fails to transform

const Test = makeTest<{ event_name?: string }>

function f() {}

Error

✘ [ERROR] Expected "}" but found "?"

    ~/test.ts:1:34:
      1 │ const Test = makeTest<{ event_name?: string }>
        │                                   ^
        ╵                                   }

@evanw
Copy link
Owner

evanw commented Feb 9, 2023

I think esbuild's copy of TypeScript's logic needs to be updated to include microsoft/TypeScript#49353 to fix this.

@evanw evanw closed this as completed in 46a6673 Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants