-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new target "baseline"/"baseline2022" #3584
Comments
I looked pretty hard for this data for ~30 minutes and couldn't find anything. Do you know if this data is published anywhere? I won't build this kind of feature without an official data source to pull from. The closest I could find was this but it's still really unclear to me what this means or how to interpret it. It would be so much easier to understand this thing if they had defined it like this (e.g. "baseline 2022" is anything that works in Chrome X, Firefox Y, and Safari X). One thing I don't understand from their complicated definition is the mental model: I can't tell if the underlying data is even of this form (or can be made to be in this form) or if it's just a hand-picked assorted list of features that don't actually map to real browser versions. It certainly seems like the features are hand-picked instead of automated based on the relevant PRs in that repo.
I think it's reasonable to have a target like |
I don't really understand it either right now 😕 But I cant for the next days, cause I'm away until sunday evening |
I asked and sent feedback and got an excellent reply in the thread linked above. It seems like perhaps this isn't a good fit for esbuild after all. The definition is intended to change over time by design (e.g. as people's preferred browsers change), which goes against my goal of deterministic builds. Browserslist (see #324) is another example of a non-deterministic target like this that I'm not planning to add to esbuild. It lets you specify targets like |
Perfect timing, I will forward this to the other Vite team members in today's meeting 👌 |
Describe what esbuild is doing incorrectly and what it should be doing instead.
Add support for new targets like
baseline
andbaseline2022
.Using these targets will result in aliases to the related browsers like
baseline2022 == [chromeX, firefoxX, safariX]
Links:
Examples:
(esbuild docs: https://esbuild.github.io/api/#target)
Provide a way to reproduce the issue.
https://esbuild.github.io/try/#dAAwLjE5LjExAC0tdGFyZ2V0PWJhc2VsaW5lMjAyMgA
https://esbuild.github.io/try/#dAAwLjE5LjExAC0tdGFyZ2V0PWJhc2VsaW5lAA
The text was updated successfully, but these errors were encountered: