Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

banner and footer flags are not honored in minified CSS #712

Closed
moos opened this issue Jan 26, 2021 · 2 comments
Closed

banner and footer flags are not honored in minified CSS #712

moos opened this issue Jan 26, 2021 · 2 comments

Comments

@moos
Copy link

moos commented Jan 26, 2021

In package.json:

    "dist-2": "esbuild src/css/main.css --bundle --minify --footer='/* Copyright 2021 Foo */' --outfile=dist/main.css",

Result: CSS is minified, but no banner/footer is added. Also @license and /*! -- */ comments in the CSS source are not honored as they are with JS bundling.

v0.8.32

@evanw
Copy link
Owner

evanw commented Jan 26, 2021

Yeah, sorry about that. This was a 3rd-party contribution and I initially missed that this was JS-only. Normally I try to make all of esbuild's features apply to both JS and CSS. I plan to fix this in the next round of breaking changes.

@susiwen8
Copy link
Contributor

susiwen8 commented Feb 8, 2021

Hi, @evanw Can I take this one? It seems not that hard to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment