Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack benchmarks are with ts-loader #973

Closed
desmap opened this issue Mar 14, 2021 · 2 comments
Closed

Webpack benchmarks are with ts-loader #973

desmap opened this issue Mar 14, 2021 · 2 comments

Comments

@desmap
Copy link

desmap commented Mar 14, 2021

A minor nitpick: I've seen that the Webpack benchmarks were done with ts-loader in the respective package.jsons. I did some intense benchmarks against babel a while ago and babel was faster. I think that esbuild should be still faster than that but just want to mention it and I'm curious how your benchmark would change with babel.

@evanw
Copy link
Owner

evanw commented Mar 14, 2021

Unfortunately @babel/plugin-transform-typescript has some limitations and only works for some TypeScript code. These limitations mean that it's not able to successfully build the TypeScript benchmark. I just tried using Babel now and Webpack gives me lots of errors of the form Identifier '___' has already been declared and warnings of the form export '___' (reexported as '___') was not found in '___'.

@evanw
Copy link
Owner

evanw commented Mar 19, 2021

Closing this for the reason above. Babel doesn't work with the TypeScript code in the benchmark.

@evanw evanw closed this as completed Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants