Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove active vehicle from configuration when API shows inconsistent results #498

Closed
andig opened this issue Dec 1, 2020 · 6 comments
Closed
Labels
enhancement New feature or request stale Outdated and ready to close

Comments

@andig
Copy link
Member

andig commented Dec 1, 2020

Active vehicle should be removed after period of repeated errors or inconsistent readings (vehicle status != charger status) even if only single vehicle configured.
Should help with #488.

@andig andig added the enhancement New feature or request label Dec 1, 2020
@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue. See dashboard for more details.

@mark-sch
Copy link
Contributor

mark-sch commented Dec 1, 2020

findActiveVehicle in der Loadpoint.go funktioniert nicht richtig, sobald die vehicle api keine valide Antwort liefert (403). Sind ein oder mehrere Fahrzeuge konfiguriert und wird dann ein nicht konfiguriertes Fremdfahrzeug (ohne Api) angesteckt, so wird fälschlicherweise das erste konfigurierte vehicle als verbunden gemeldet (ist es aber nicht).

@andig
Copy link
Member Author

andig commented Dec 4, 2020

Refs mark-sch@03450ae

@andig
Copy link
Member Author

andig commented Dec 7, 2020

Depends on #505

@andig
Copy link
Member Author

andig commented Dec 16, 2020

Wir haben noch keine konkreten Vorschläge wie das umgesetzt werden sollte, insbesondere in Anbetracht der jetzt selteneren Vehicle Updates. Wenn's keine Ideen gibt würde ich hier erstmal als "works as implemented" zumachen.

@stale
Copy link

stale bot commented Feb 4, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Outdated and ready to close label Feb 4, 2021
@stale stale bot closed this as completed Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale Outdated and ready to close
Projects
None yet
Development

No branches or pull requests

2 participants