Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planner: continue in PV mode when planner finishes #6910

Closed
andig opened this issue Mar 18, 2023 · 5 comments
Closed

Planner: continue in PV mode when planner finishes #6910

andig opened this issue Mar 18, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@andig
Copy link
Member

andig commented Mar 18, 2023

From Slack: we should think about splitting the planner target soc from the actual target, i.e. treat planner more as a minimum value.

/cc @naltatis

@andig andig added the enhancement New feature or request label Mar 18, 2023
@naltatis
Copy link
Member

I get the idea, but I think we are introducing a lot of complexity where. We'll have to visualize this extra SoC limit in addition to the existing ones (min soc, target soc, vehicle limit). In addition it's not obvious to the user which soc is the limit. As an example: I use target time before longer trips. In these scenarios I want the vehicle reach a higher soc (100%) than my usual limit (80%). But you could also make the case the other way around where it's more of a minimum value as you described.

I'm not sure if it's wise to open this topic right now. I see that we have work to do here especially when we are thinking about departure schedules / recurring targets. see #5492

@Da-ne-ezy
Copy link

For the visualization you could simply insert 2 bars/slider instead of currently only one bar/slider. The first bar sets the minSOC and the second the target SOC.

@andig
Copy link
Member Author

andig commented Mar 24, 2023

I think the real point here is that we should treat the planner soc as a minsoc with timestamp rather than as a targetsoc.

@github-actions github-actions bot added the stale Outdated and ready to close label Apr 14, 2023
@andig andig removed the stale Outdated and ready to close label Apr 14, 2023
@github-actions github-actions bot added the stale Outdated and ready to close label May 5, 2023
@andig andig removed the stale Outdated and ready to close label May 8, 2023
@andromedavpn
Copy link

andromedavpn commented May 15, 2023

As a naive user who didn't read the doc, the described behavior was actually my expectation for min+PV mode. Eventually this is also my main use case, preserve a minimum SoC for daily trips and in case of PV surplus charge to max.

@andig
Copy link
Member Author

andig commented May 20, 2023

It is unlcear what this issue should achieve. Planner uses target soc. Once target is achieved, PV mode would stop charging as well. We might revisit this behaviour once we address #5492.

@andig andig closed this as completed May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

4 participants