Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evemon crashing on citadel contracts #38

Open
privatemeta opened this issue Nov 28, 2016 · 3 comments
Open

Evemon crashing on citadel contracts #38

privatemeta opened this issue Nov 28, 2016 · 3 comments

Comments

@privatemeta
Copy link

When creating, changing, deleting or accepting a contract that is based in citadels, evemon crashes. The bug happens when hovering over the magnifying glass or x on the citadel contract notification.

See bug report here
https://forums.eveonline.com/default.aspx?g=posts&m=6600926#post6600926

@elliena-bulmer
Copy link
Contributor

@privatemeta I'll try to have a look at the issue and have a fix before the next version released.

@privatemeta
Copy link
Author

Apparently this also happens when selling stuff on citadel markets (and market change notifications come in)

@adi-tetac
Copy link

I keep getting this more with the market since I have more market orders than contracts, here are links to the functions the errors point to that I think the issue is with.
Market function from errors
https://github.com/evemondevteam/evemon/blob/master/src/EVEMon/Controls/NotificationList.cs#L622
line I suspect
.AppendLine(order.Station.Name);
https://github.com/evemondevteam/evemon/blob/master/src/EVEMon/Controls/NotificationList.cs#L650
Contract function from errors
https://github.com/evemondevteam/evemon/blob/master/src/EVEMon/Controls/NotificationList.cs#L661
line I suspect
.AppendLine(contract.StartStation.Name);
https://github.com/evemondevteam/evemon/blob/master/src/EVEMon/Controls/NotificationList.cs#L690

Its been a few years since I've touched C# but would changing .AppendLine(contract.StartStation.Name); to .AppendLine(contract.StartStation.Name ?? "Citadel"); or something similar work? or am I misremembering how it works/misidentifying the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants