Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command: @cpattr #26

Closed
Griatch opened this issue Jan 21, 2014 · 13 comments
Closed

Command: @cpattr #26

Griatch opened this issue Jan 21, 2014 · 13 comments
Labels
feature-request A suggestion for new functionality.

Comments

@Griatch
Copy link
Member

Griatch commented Jan 21, 2014

From squishywaffle@gmail.com on May 29, 2007 04:45:43

Implement as per @cpattr.

Original issue: http://code.google.com/p/evennia/issues/detail?id=26

@Griatch
Copy link
Member Author

Griatch commented Jan 21, 2014

From tsalar...@gmail.com on August 07, 2007 10:40:13

Owner: tsalaroth

@Griatch
Copy link
Member Author

Griatch commented Jan 21, 2014

From tsalar...@gmail.com on September 14, 2007 10:08:41

Owner: ---

@Griatch
Copy link
Member Author

Griatch commented Jan 21, 2014

From jamesvclemence@gmail.com on January 13, 2009 05:14:01

Owner: jamesvclemence

@Griatch
Copy link
Member Author

Griatch commented Jan 21, 2014

From jamesvclemence@gmail.com on January 13, 2009 05:14:55

I'm very happy to take on this one, I do have a few questions before I start work,
but will ask them when I have a moment!

@Griatch
Copy link
Member Author

Griatch commented Jan 21, 2014

From jamesvclemence@gmail.com on January 13, 2009 09:27:33

Status: Started

@Griatch
Copy link
Member Author

Griatch commented Jan 21, 2014

From squishywaffle@gmail.com on January 17, 2009 19:02:56

Labels: -Priority-Medium Priority-High

@Griatch
Copy link
Member Author

Griatch commented Jan 21, 2014

From jamesvclemence@gmail.com on January 23, 2009 09:57:09

First draft implemented and issues found already fixed. Any further issues please
contact me.

Status: Implemented

@Griatch
Copy link
Member Author

Griatch commented Jan 21, 2014

From squishywaffle@gmail.com on January 24, 2009 11:01:41

It looks like your editor is using tabs instead of spaces. Please make sure you're
indenting with 4 spaces, and not tabs. It really messes up things for the rest of us.
Take a peek at the Code Style document on the wiki at code.evennia.com.

Thanks!

@Griatch
Copy link
Member Author

Griatch commented Jan 21, 2014

From jamesvclemence@gmail.com on January 24, 2009 11:31:33

Corrected, my apologies, it should all be fixed now, please let me know if not - I'd
intended to do spaces as per the code style but a config error got in the way.

@Griatch
Copy link
Member Author

Griatch commented Jan 21, 2014

From squishywaffle@gmail.com on January 24, 2009 12:52:35

I've got to re-open this, it doesn't work as per MUX2's syntax. Also, take a look and
note that you don't have to figure out if attributes already exist for the sake of
either updating or creating them, you can just use object.set_attribute("someattrib",
"someval") (which does that for you).

This is a bit of a complex one due to the four different styles of the command. What
I'd suggest is breaking it out into another module under the commands directory and
compartmentalize it out so it's easy to follow and doesn't pollute objmanip.py with
extra functions.

I've updated the comment docstring to reflect the full MUX2 syntax. You've got a good
bit of the work done already, you just need to write it in such a way that you're not
duplicating code for each of the syntaxes. See @search for some ideas, that has a lot
of different arrangements.

Status: Started

@Griatch
Copy link
Member Author

Griatch commented Jan 21, 2014

From jamesvclemence@gmail.com on January 25, 2009 10:15:46

Thats fine, my apologies I didn't realise the multiplicity of cpattr syntax! I'm
pretty busy the next few days but I'll run with hacking on it over the next week or
so. Cheers for the pointers, I had realised the set_attribute thing I'd taken a look
a couple of days ago, but hadn't updated the code accordingly.

Thanks once again I'll get you a more functioning commit in about a week.

@Griatch
Copy link
Member Author

Griatch commented Jan 21, 2014

From squishywaffle@gmail.com on April 27, 2009 10:35:07

This hasn't seen action for a long time, opening it back up to whoever wants to
implement it as per MUX/MUSH.

Status: Accepted
Owner: ---

@Griatch
Copy link
Member Author

Griatch commented Jan 21, 2014

From griatch on August 29, 2009 12:16:43

Implemented as per MUX specifications.

Status: Implemented
Owner: griatch

@Griatch Griatch closed this as completed Jan 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A suggestion for new functionality.
Projects
None yet
Development

No branches or pull requests

1 participant