Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load stream events #2

Open
codeliner opened this issue Apr 7, 2020 · 2 comments · May be fixed by #3
Open

Load stream events #2

codeliner opened this issue Apr 7, 2020 · 2 comments · May be fixed by #3
Assignees

Comments

@codeliner
Copy link
Contributor

We should add two more methods to the event store interface:

  • loeadStreamEvents
  • loeadStreamEventsReverse

Both should be similar to loadAggregateEvents but only use the stream name as filter.
Instead of minVersion and maxVersion the methods should take skip and limit arguments so that clients can implement pagination logic while browsing a stream.

@codeliner codeliner self-assigned this Apr 7, 2020
@HolgerDoerner HolgerDoerner linked a pull request Oct 9, 2020 that will close this issue
@HolgerDoerner
Copy link

Hello @codeliner , I didn't realized that You had already assigned Yourself to this Issue when I created the PR 😞
But if You don't mind, I would really appreciate it if You would accept my PR. And if You would also label this Issue and/or the PR for Hacktoberfest, I would be very happy 😄

@codeliner
Copy link
Contributor Author

Hey @HolgerDoerner, thank you for your contribution. Yeah, I assigned the issue to myself as a reminder. Adding the methods to the interface is only half of the story ;) The real work needs to be done in the prooph/event-store bridge here: https://github.com/event-engine/prooph-v7-event-store/blob/master/src/ProophEventStore.php#L26

I can only merge your PR if the methods are implemented in the bridge ☝️ and some tests are added there, too.
prooph/event-store provides the functionality, so the bridge just has to translate. Should be straight forward. You can work on it, if you want. If you have questions, ask anytime. I don't have time at the moment to work on it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants