fetch should be in try-catch

[iegik]

fetch should be in try-catch because of possible error on request.
There is no try-catch on https://github.com/eventbrite/eventbrite-sdk-javascript/blob/master/src/request.ts#L42

export default (...args) => {
    try {
        return fetch(...args)
    } catch (e) {
        return Promise.reject(e);
    }
};

or

export default async (...args) => {
    try {
        return await fetch(...args)
    } catch (e) {
        return e;
    }
};

https://gist.github.com/iegik/3a69da2034156d52b858096ba3aa26f6

[benmvp]

Thanks for the help!

So a timeout in the fetch call wouldn't reject the promise?

[iegik]

@benmvp Sorry, I can't reproduce for now, but in some cases I've got JS error on fetch execution. Maybe it was ReactNative 54 bug, I don't remember.
I did not find how to emulate "no response" error, but Timeout and Offline can catch in catch.

• https://bugs.chromium.org/p/chromium/issues/detail?id=84313
• ☂ "Unable to load the page"  GoogleChrome/lighthouse#2784

const addButton = (url, options) => {
    a = document.createElement('button');
    document.body.appendChild(a);
    a.innerText = [url, JSON.stringify(options)];
    a.onclick = e => {
        fetch(url, options).then(resp => {
          console.log('resp', resp)
        }).catch(e => {
          console.error('Catched error', e)
        })
    }
}
addButton('https://example.com'); // net::ERR_INTERNET_DISCONNECTED when Offline
addButton('https://example.com:81'); // net::ERR_CONNECTION_TIMED_OUT

[ryanwholey]

@iegik thanks for clarifying! maybe we should close this issue until we can reproduce?

[benmvp]

Yep, I think we should. We can always reopen if the issue arises