Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect spelling of "Chunk" #36

Open
mrosales opened this issue Feb 27, 2020 · 1 comment · May be fixed by #39
Open

Incorrect spelling of "Chunk" #36

mrosales opened this issue Feb 27, 2020 · 1 comment · May be fixed by #39

Comments

@mrosales
Copy link

In a handful of places the word "chunk" is spelled Chunck, which makes for an awkward public API call of uploader.UploadChunck.

It would be annoying to fix since its a breaking change, but it might still be nice to do so. Maybe if you didn't want to make a breaking API change you could just redirect the existing public functions that are spelled incorrectly and mark them as deprecated?
@jaswdr
Copy link

jaswdr commented Apr 6, 2020

@mrosales can you send a PR for that?

@mrosales mrosales linked a pull request Apr 17, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix spelling of chunk and update tusd version mrosales/go-tus
2 participants
@mrosales @jaswdr