Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wsgi greenpool assertion failure on waitall #207

Open
brantlk opened this issue Mar 2, 2015 · 2 comments
Open

wsgi greenpool assertion failure on waitall #207

brantlk opened this issue Mar 2, 2015 · 2 comments
Labels
feature-wsgi need-test

Comments

@brantlk
Copy link

brantlk commented Mar 2, 2015

1c30e9b added some code to call pool.waitall() in the finally block for wsgi.server.

pool.waitall() asserts that greenthread.getcurrent() not in self.coroutines_running, so that if I'm running a wsgi.server in a green pool then it'll always assert when breaking out of the accept loop.

I don't know what the fix is other than to check beforehand the condition that would call waitall to assert and don't call waitiall if it would assert.
@brantlk
Copy link
Author

brantlk commented Aug 21, 2017

Closing since this has been open for a long time.

@brantlk brantlk closed this as completed Aug 21, 2017
@temoto
Copy link
Member

temoto commented Aug 21, 2017

Sorry, I didn't see this issue.

Can you post a piece of code to reproduce this problem?

@temoto temoto reopened this Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-wsgi need-test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@temoto @brantlk