Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GreenSSLSocket.settimeout should be implemented as python docs. #505

Open
jiajunsu opened this issue Jul 6, 2018 · 0 comments
Open

GreenSSLSocket.settimeout should be implemented as python docs. #505

jiajunsu opened this issue Jul 6, 2018 · 0 comments

Comments

@jiajunsu
Copy link
Contributor

jiajunsu commented Jul 6, 2018

In python docs, it says s.settimeout(0.0) is equivalent to s.setblocking(0).

But in eventlet code green.ssl, we don't deal with the scenario of timeout=0.0, while we implement that in greenio.

That difference leads to an error in kafka-python, in SASL_SSL mode

Maybe we should consider to make the conditional branch of timeout=0.0 same between ssl and non-ssl scenario, or at least give a recommendation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant