Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

describe partitions statement #253

Merged
merged 29 commits into from Sep 26, 2016
Merged

describe partitions statement #253

merged 29 commits into from Sep 26, 2016

Conversation

lauraschlimmer
Copy link
Member

@asmuth
Copy link
Member

asmuth commented Sep 19, 2016

sieht generell gut aus, ein paar kleine sachen:

  • CHANGELOG eintrag fehlt
  • In der dokumentation wuerde ich DESCRIBE und DESCRIBE PARTITIONS als getrennte seiten machen. waere auch nice ein paar saetze richtige doku zu haben. also z.b. ein beispiel usw
  • Ich haette das PartitionInfo struct nicht in den csql namespace gepackt, sondern in den eventql namespace

@asmuth asmuth added this to the EventQL v0.5.0 milestone Sep 19, 2016
@lauraschlimmer
Copy link
Member Author

please have a look again


bool DescribePartitionsExpression::next(SValue* row, size_t row_len) {
if (counter_ < rows_.size()) {
const auto& col = rows_[counter_];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why col, not row?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as the method's first argument is named 'row', I changed 'col' to 'partition'

}
server_ids += col.server_ids[i];
}
row[2] = SValue::newString(server_ids); //Server id
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StringUtil::join(server_ids, ", ")

@asmuth
Copy link
Member

asmuth commented Sep 21, 2016

generell waere es gut noch zwei andere columns auszugeben:

  • noch "Extra info" wie auch in der weboberflaeche wo z.b. drinsteht ob die partition grade splittet und wo us (genau wie in der weboberflaeche)
  • keyrange end (das ist unterschiedlich jenachdem ob das metadata file hasFinitePartitions hat. wenn ja, dann ist das ende einfach der "end" member der PartitionMapEntries. Wenn nein, ist das ende der begin der naechsten partition oder "" (empty string) wenn es die letzte partition ist)

@lauraschlimmer
Copy link
Member Author

please have a look again

@asmuth asmuth merged commit 9152317 into master Sep 26, 2016
@asmuth asmuth deleted the feature/descr_partitions_stmt branch September 26, 2016 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants