New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
describe partitions statement #253
Conversation
…r_partitions_stmt
…r_partitions_stmt
sieht generell gut aus, ein paar kleine sachen:
|
…r_partitions_stmt
please have a look again |
|
||
bool DescribePartitionsExpression::next(SValue* row, size_t row_len) { | ||
if (counter_ < rows_.size()) { | ||
const auto& col = rows_[counter_]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why col, not row?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as the method's first argument is named 'row', I changed 'col' to 'partition'
} | ||
server_ids += col.server_ids[i]; | ||
} | ||
row[2] = SValue::newString(server_ids); //Server id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StringUtil::join(server_ids, ", ")
generell waere es gut noch zwei andere columns auszugeben:
|
please have a look again |
#245