Problem: Command#onCompletion method name is confusing #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It sounds like a callback, while in fact it is a function that takes a state from an EventStream and produces a "result" Solution: rename it to `#result()` Also, change the order of type parameters for Command from Result, State to State, Result to follow the order of their dependency.
|
Merged myself because I am attending an event tonight (http://www.meetup.com/bkkhack/events/23086315), want to show what's going on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It sounds like a callback, while in fact it is a function that takes
a state from an EventStream and produces a "result"
Solution: rename it to
#result()Also, change the order of type parameters for Command from Result, State
to State, Result to follow the order of their dependency.