Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServerFeatures should only assume unknown server on UNIMPLEMENTED error #309

Closed
George-Payne opened this issue Aug 17, 2022 · 0 comments · Fixed by #311
Closed

ServerFeatures should only assume unknown server on UNIMPLEMENTED error #309

George-Payne opened this issue Aug 17, 2022 · 0 comments · Fixed by #311
Labels
kind/bug Issues which are a software defect

Comments

@George-Payne
Copy link
Member

George-Payne commented Aug 17, 2022 •
edited
Loading

Currently ServerFeatures will ignore all errors and assume an unknown server version if the request for features errors.

It should only assume unknown if the endpoint isn't available (UNIMPLEMENTED) and throw other errors, like unable to connect.

Originally posted by @ylorph in #307 (review)
@George-Payne George-Payne added the kind/bug Issues which are a software defect label Aug 18, 2022
@George-Payne George-Payne mentioned this issue Aug 22, 2022
Merged
@George-Payne George-Payne changed the title ServerFeatures should only assume unknown server on NOT_FOUND error ServerFeatures should only assume unknown server on UNIMPLEMENTED error Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Issues which are a software defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only swallow UNIMPLEMENTED errors when creating server-features EventStore/EventStore-Client-NodeJS
1 participant
@George-Payne