Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding better isViewInBounds check #3

Open
AhmedvHashem opened this issue Jul 16, 2017 · 2 comments
Open

adding better isViewInBounds check #3

AhmedvHashem opened this issue Jul 16, 2017 · 2 comments

Comments

@AhmedvHashem
Copy link
Member

We salute you for this library, we are using it in our current project, it saved us a lot of time.

i added an extra functionality that was needed, and i think it should be default it the library

when you move the image/sticker/text vertically the isViewInBounds() works perfectly but when moving horizontally it does not cuz it fits the width of the screen to the touch position never exceed the bounds of the container view.

so i added that functinallity

my fork https://github.com/AhmedNTS/photo-editor-android

@haykgalstyan
Copy link

Thank you!

@sreekanth100khere
Copy link

@AhmedNTS Since you are using this in your project, I am considering this for my project, are there any bugs with this library?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants