Skip to content
This repository has been archived by the owner on Nov 2, 2020. It is now read-only.

Use docker for psql #17

Closed
2 tasks
Fohlen opened this issue Sep 23, 2019 · 3 comments · Fixed by #23
Closed
2 tasks

Use docker for psql #17

Fohlen opened this issue Sep 23, 2019 · 3 comments · Fixed by #23
Labels
documentation Documentation is not fit as a fiddle good first issue Good for newcomers Hacktoberfest Happy Hacktoberfest! help wanted Extra attention is needed

Comments

@Fohlen
Copy link
Contributor

Fohlen commented Sep 23, 2019 •
edited

In the SETUP.md currently psql is a hard requirement. It is possible to use psql directly from the container. In order to do so, we also need to mount the fixtures folder into the container.

  • Rewrite the SETUP.md to use docker run -it --rm variant of psql
  • Remove psql as a hard requirement
@Fohlen Fohlen added help wanted Extra attention is needed good first issue Good for newcomers documentation Documentation is not fit as a fiddle Hacktoberfest Happy Hacktoberfest! labels Sep 23, 2019
@fgehrlicher
Copy link
Contributor

Can I take this up?

@Fohlen
Copy link
Contributor Author

Fohlen commented Oct 1, 2019

Hey, yes, I'd love to see your PR! Thanks for taking it on.

@Fohlen
Copy link
Contributor Author

Fohlen commented Oct 1, 2019

If you want to reference the db host I believe you can use exec to resolve the address (instead of localhost)

This was referenced Oct 2, 2019
Merged
Merged
@Fohlen Fohlen closed this as completed in #23 Oct 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
documentation Documentation is not fit as a fiddle good first issue Good for newcomers Hacktoberfest Happy Hacktoberfest! help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace all psql commands with docker exec ones fgehrlicher/schema
2 participants
@Fohlen @fgehrlicher