Skip to content
This repository has been archived by the owner on Oct 27, 2021. It is now read-only.

Generalize the scheming #33

Closed
akselinurmio opened this issue Aug 14, 2018 · 0 comments · Fixed by #34
Closed

Generalize the scheming #33

akselinurmio opened this issue Aug 14, 2018 · 0 comments · Fixed by #34

Comments

@akselinurmio
Copy link
Contributor

In the current state text colors of the schemes are only applied on p, ul, li and span elements. This causes elements not included here not to inherit the right coloring.

Expected behavior

When the scheme is applied to an element using scheme-html derivatives such as scheme-html-default, the text and link coloring should be set equally for all elements, including but not limited to plain <div>s, tables, description lists, figures and preformatted texts.

Current behavior

Scheme only colors links in paragraphs and text in lists, paragraphs and <span>s.

Context (Environment)

Scheming should work anywhere. It shouldn't matter what elements you are using in your actual code. By specifying text colors in more general level, we also ease debugging of our components' coloring. Also text-color related features as for example currentColor work more reliably.

Possible solution

Remove element specific selectors from _scheme-html.scss.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant