Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same Wallpaper on all Screens #1

Closed
mjot opened this issue Jul 18, 2019 · 3 comments
Closed

Same Wallpaper on all Screens #1

mjot opened this issue Jul 18, 2019 · 3 comments
Labels
good first issue Good for newcomers

Comments

@mjot
Copy link

mjot commented Jul 18, 2019

Hello,

first of all thank you for this great app. It's really amazing to have these great photos on my screen so easily.

But I have a question or rather a feature request. Would it be possible to display the same wallpaper on all screens? I am currently using 2 external screens and PrettyEarth only changes the background image of my main screen.

That would be great, thank you very much.

@evertdespiegeleer
Copy link
Owner

evertdespiegeleer commented Jul 18, 2019

Thanks! That's great to hear.

I have thought about this during development, but there are a few reasons I haven't implemented it:

  • It's surprisingly difficult and hacky to reliably change the wallpaper on a Mac programatically. Here's the code that does that. As you can see it doesn't actually happen reliably. The code doesn't (and can't) check if the wallpaper really changes, it just throws the command at the computer and assumes it works. I tested it a lot and it never failed so it seems to work, but to my knowledge there's no check/callback possible. I tried other ways than AppleScript to do to the switching but this turned out to be the best one, and it's still pretty ugly code. It seemed to always work this way so I just carefully left it there and never touched it again.
  • I actually incorrectly assumed it changed the wallpaper on all the screens, but I should have checked that
  • I only have 1 screen which makes testing pretty difficult

However, I've read your feature request a few times on multiple platforms, so I will look into it.
I'm trying not to deviate from the AppleScript-solution, but I do think it can be done with AppleScript.

Thanks for the feedback!

@evertdespiegeleer
Copy link
Owner

@akramsaouri Fixed this. Thanks!

@mjot
Copy link
Author

mjot commented Aug 12, 2019

Could you create a new release? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants