Added avatars support for PS3 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice pull request, congratulations. From what I see and from what I remember from my own code (not much xD) you seem to have tested everything. Since everything seem to be fine I'll just merge it into master and run my tests over there. |
|
Yay! I hope I didn't miss anything tho. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again! I redownloaded your latest version and re-did my avatars support addition.
This time I tried to go through the safety a bit more and not just to make it work.
I used the parts you already got to show warning and error messages to the user regarding Avatars download.
I'm happy for inputs :)