Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all pages have an associated page class #15561

Open
octopusinvitro opened this issue Sep 21, 2016 · 0 comments
Open

Make all pages have an associated page class #15561

octopusinvitro opened this issue Sep 21, 2016 · 0 comments

Comments

@octopusinvitro
Copy link
Contributor

Problem

We are still in an intermediate state where we send a page object to the relevant template for some routes but not for others. This causes some warnings when running the tests and is a bit inconsistent.

Proposed Solution

Make a dedicated page class for the templates that contain variables and don't use a page.

Acceptance Criteria

Every template that has variables on it should have an associated page class that contains everything the template needs to be rendered.

@octopusinvitro octopusinvitro changed the title Make all pages have a page Make all pages have an associated page class Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants