Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SASS sources and wrappers #9

Closed
dmhendricks opened this issue Jan 19, 2018 · 1 comment
Closed

SASS sources and wrappers #9

dmhendricks opened this issue Jan 19, 2018 · 1 comment

Comments

@dmhendricks
Copy link

Excellent framework. Nice job.

It would be nice if SASS source files were available. I mention it because I'd like to wrap the whole thing in a wrapper class. Ex:

<div class="flexgrid2-wrapper">
  <div class="container">
    <div class="row">
      <div class="col-xs-12">
        ...
      </div>
    </div>
  </div>
</div>

The reason is because I often like to link to small grid libraries when I work on existing sites that have lousy themes/no grids. It makes adding custom content quick and easy (especially with Magento sites - they almost always have no grid framework and a terrible - but I use it frequently with WordPress sites, too). However, I like to wrap it in a unique class so not to (potentially) collide with other classes similarly named (like .row, .container, etc - they are rather common names). I currently do this with bootstrap-grid-css, however, I am sick of maintaining it and I like your framework better.

Also, is there a reason that child elements like .row and .col-* aren't nested under the .container classes? Just curious.

Anyway, just throwing out some ideas. Keep up the good work.

Daniel

@imevro
Copy link
Owner

imevro commented Feb 21, 2018

We don’t use sass.

@imevro imevro closed this as completed Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants