Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thank you for creating this. A suggestion for faster retrievals #1

Open
demircancelebi opened this issue Aug 16, 2020 · 0 comments
Open

Comments

@demircancelebi
Copy link

demircancelebi commented Aug 16, 2020

Hello @enesusta,
Thank you for creating this, it'd probably help a lot of people.

Looking at your data structure and code, it looks like you have to do nested lookups for specific locations (in functions like GetVillagesOfCounty, GetVillagesOfTown), which is not ideal. I think we can discuss here and find a better way. Alternatives I can think of are:

  • Restructuring the JSON
    We might have a different json structure that allows fast retrievals, but it would require extra tooling
  • Using SQLite and/or Parquet files
    This would probably take the project to a completely different realm, but considering that the file PTT releases is changing often it should be simpler to work with the released file since we'd avoid the extra steps in your parser work. I think we can get pretty fast retrievals with indexing.

Any other thoughts from anyone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant