Skip to content
This repository has been archived by the owner on Jan 2, 2021. It is now read-only.

Spaces aren't allowed in folder names #10

Closed
Nobrumski opened this issue Sep 15, 2012 · 6 comments
Closed

Spaces aren't allowed in folder names #10

Nobrumski opened this issue Sep 15, 2012 · 6 comments
Assignees

Comments

@Nobrumski
Copy link

It seems Mylar won't allow my folder structure. I thought originally it was due to the publisher folder, but then I realized it doesn't let me save the destination due to the spaces.

For example D:\Ecomics\DC Comics\Action Comics (2011) and D:\Ecomics\Action Comics (2011) don't save when you try to save the path under the individual comics.

Running latest git on Win 7.
When I told Mylar my default path was D:\Ecomics it used this for the path for Action Comics
D:\Ecomics\Action_Comics_(2011)

@evilhero
Copy link
Owner

It actually doesn't have anything to do with your path :) Mylar currently only uses the default path that you specify in the Configuration/Comic Location section. All folders are created beneath that path.

The individual comic path that you're trying to set, well it doesn't quite work...I thought I blanked out that part of the template but I guess it made it back in there in the last commit - I'm just trying to finalize the code so that you can specifiy individual settings per comic, but until that time everything flies underneath the default path. You did point out something else though that I did a boo-boo on in the last commit - if you don't specify a character for replace spaces in the configuration (or check it off), it will remove the spaces entirely. Next commit will fix that part.

@ghost ghost assigned evilhero Sep 15, 2012
@Nobrumski
Copy link
Author

Hmm okay then I may have to wait for individual paths then since I would have to change a bunch of stuff to really test it. One solution would be to add the publisher folder as part of the default path if possible. Then I could just tweak the logic in the comicrack move library script so the folders were named the same.

On Sep 15, 2012, at 2:58 PM, evilhero notifications@github.com wrote:

It actually doesn't have anything to do with your path :) Mylar currently only uses the default path that you specify in the Configuration/Comic Location section. All folders are created beneath that path.

The individual comic path that you're trying to set, well it doesn't quite work...I thought I blanked out that part of the template but I guess it made it back in there in the last commit - I'm just trying to finalize the code so that you can specifiy individual settings per comic, but until that time everything flies underneath the default path. You did point out something else though that I did a boo-boo on in the last commit - if you don't specify a character for replace spaces in the configuration (or check it off), it will remove the spaces entirely. Next commit will fix that part.


Reply to this email directly or view it on GitHub.

@evilhero
Copy link
Owner

Definitely will be customizable to that level (my hope at least) - changing this to an Enhancement request as a reminder for myself in case I get sidetracked doing something else.

@evilhero
Copy link
Owner

Changing the default path for individual comics is now in the latest commit. It's reachable by going into the Edit tab for each Comic on the Comic Detail page. I expect there to be a few bugs (mainly with checking files thereafter - depending on directory existance is one I know of), but Mylar does not delete / remove any files from your comic paths, so it should be safe in that regards (for those wondering).

@Nobrumski
Copy link
Author

Thanks. It looks like it is working well.

One idea though maybe I should make another issue for it. It would be nice if you could add existing folders similar to how Sickbeard does it. This way it would add the folder and search based off the folder name rather than adding a series and having to go in and edit it after the fact.

@evilhero
Copy link
Owner

Yeah I like the idea and tossed it around abit briefly - the only reason it was briefly was because of the way the 'add a series' basically works now, it would mean a pretty big rewrite. If you make another issue (or enhancement request), I'll mark it and see what I can do for sure.

@evilhero evilhero closed this as completed Sep 9, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants