Skip to content
This repository has been archived by the owner on Jan 2, 2021. It is now read-only.

Never get comic info 2- Out of range #3

Closed
nicksmith53 opened this issue Sep 10, 2012 · 8 comments
Closed

Never get comic info 2- Out of range #3

nicksmith53 opened this issue Sep 10, 2012 · 8 comments
Assignees
Labels

Comments

@nicksmith53
Copy link
Contributor

When trying to add some comics, the info for the comic itself (main cover, publisher, # of issues, etc.) will download, but none of the actual issues do ("No issue information available").

The only error is in the command line:

10-Sep-2012 04:29:44 - INFO :: Thread-12 : Now adding/updating: Grimm Fairy Tales
ID: /series/23514/
10-Sep-2012 04:29:53 - INFO :: Thread-12 : Sucessfully retrieved details for Grimm Fairy Tales
10-Sep-2012 04:29:53 - INFO :: Thread-12 : Directory successfully created at: C:\Users\nick\Documents\Comics/Grimm_Fairy_Tales_(2005)
10-Sep-2012 04:29:54 - INFO :: Thread-12 : Sucessfully retrieved issue details for Grimm Fairy Tales
Exception in thread Thread-12:
Traceback (most recent call last):
  File "C:\Python27\lib\threading.py", line 551, in __bootstrap_inner
    self.run()
  File "C:\Python27\lib\threading.py", line 504, in run
    self.__target(*self.__args, **self.__kwargs)
  File "C:\Users\nick\WebSpace\git\mylar\mylar\importer.py", line 150, in addComictoDB
    firstval = issued['issuechoice'][n]
IndexError: list index out of range
@nicksmith53
Copy link
Contributor Author

Oops, that wasn't what I wanted

@ghost ghost assigned evilhero Sep 10, 2012
@evilhero
Copy link
Owner

I just had this happen to me late last night (like @4am EST) so haven't been able to look into it although from what I gathered really quickly it's a problem with the parser and the values it's returning. Will look into it more today and hopefully git'r'done!

@evilhero
Copy link
Owner

Ok, kinda weird - I just added Grimm Fairy Tales as you did and didn't get any errors. I didn't think I had made any changes to importer.py last night although it was pretty late so it's possible. Can you confirm you're still having issues with it? Try deleting the comic first maybe, then readding it and see if that helps - I'll check my version of it and see if I did anything in the meantime.

2012-09-10 14:57:58     INFO    No issues marked as wanted for Grimm Fairy Tales
2012-09-10 14:57:58     INFO    Updating complete for: Grimm Fairy Tales
2012-09-10 14:57:56     INFO    Found 0 issues of Grimm Fairy Tales
2012-09-10 14:57:56     INFO    Checking directory for existing issues.
2012-09-10 14:57:56     INFO    Now adding/updating issues forGrimm Fairy Tales
2012-09-10 14:57:56     INFO    Sucessfully retrieved issue details for Grimm Fairy Tales
2012-09-10 14:57:55     INFO    Directory successfully created at: /mount/mediavg/Comics/Comics/Grimm_Fairy_Tales_(2006)
2012-09-10 14:57:55     INFO    Sucessfully retrieved details for Grimm Fairy Tales
2012-09-10 14:57:49     INFO    Now adding/updating: Grimm Fairy Tales

@nicksmith53
Copy link
Contributor Author

I"m still having the same problem at 89e9423.

--edit--
ah ha, you successfully added a different comic. I'm looking for Grimm_Fairy_Tales_(2005) with 77 issues.

@evilhero
Copy link
Owner

Yep you're right lol....I just treid the 2005 version and got this :

2012-09-10 21:18:03     INFO    Found 0/77 issues of Grimm Fairy Tales
2012-09-10 21:18:03     INFO    Checking directory for existing issues.
2012-09-10 21:18:03     INFO    Now adding/updating issues forGrimm Fairy Tales
2012-09-10 21:18:03     INFO    Sucessfully retrieved issue details for Grimm Fairy Tales
2012-09-10 21:18:02     INFO    Directory successfully created at: /mount/mediavg/Comics/Comics/Grimm_Fairy_Tales_(2005)
2012-09-10 21:18:01     INFO    Sucessfully retrieved details for Grimm Fairy Tales
2012-09-10 21:17:41     INFO    Now adding/updating: Grimm Fairy Tales

So it doesn't work, but it got farther along than that version. I'm not quite sure exactly where it's losing it's marbles and why it's only for some and not others - I have a feeling it's in the secondary parsing that's causing the total issue counts to be off somehow. I'm still looking into it some more ...

@evilhero
Copy link
Owner

Well on the plus...

2012-09-10 22:56:59     INFO    No issues marked as wanted for Grimm Fairy Tales
2012-09-10 22:56:59     INFO    Updating complete for: Grimm Fairy Tales
2012-09-10 22:56:40     INFO    Found 0/77 issues of Grimm Fairy Tales
2012-09-10 22:56:40     INFO    Checking directory for existing issues.
2012-09-10 22:56:40     INFO    Now adding/updating issues forGrimm Fairy Tales
2012-09-10 22:56:40     INFO    Sucessfully retrieved issue details for Grimm Fairy Tales
2012-09-10 22:56:38     INFO    Directory (/mount/mediavg/Comics/Comics/Grimm_Fairy_Tales_(2005)) already exists! Continuing...
2012-09-10 22:56:38     INFO    Sucessfully retrieved details for Grimm Fairy Tales
2012-09-10 22:56:16     INFO    Now adding/updating: Grimm Fairy Tales

It works now - unfortunately in reworking the code I have to account for issues that are like '14.10' instead of '14.00' which throws out my comparison operations....sigh, at least this I can fix easily :) New commit will be up with the new importer.py in an hour or two :)

@nicksmith53
Copy link
Contributor Author

Sweet. I was starting to poke around, hoping to find a simple fix, and was just making more problems.

@nicksmith53
Copy link
Contributor Author

Looking good. Looks like 60fb2cf fixes it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants