-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve call_lefthook #250
Comments
Oh, wait, I see there already is this So, this needs a fix too. It would be way simple to add this, IMO: |
I am experiencing the same issue, it takes too long to call it using npx. |
Do we know why the PR was closed? I'd love to see a solve for pnpm, at the very least |
I think the best way is to completely avoid dynamic installing lefthook like with npx and just stick with what could be locally installed and otherwise exit with a hint. I don't know why it was closed but maybe because of bad grammar or typos or style idk. |
When only using pnpm
call_lefthook
takes 20 seconds to call, because npx just takes so long.Solution is adding
pnpm
before npx (and maybe move yarn before npx too) so these can callnode_modules
bin before using npx.The text was updated successfully, but these errors were encountered: