Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-S for the bmap-tool is not completely done #56

Closed
benleb opened this issue Oct 2, 2019 · 6 comments
Closed

-S for the bmap-tool is not completely done #56

benleb opened this issue Oct 2, 2019 · 6 comments

Comments

@benleb
Copy link
Contributor

benleb commented Oct 2, 2019

./create_sibling.sh: illegal option -- S

seems like the option is documented but not (fully) implemented. probably this was missed in #41 ?

@caquino
Copy link
Contributor

caquino commented Oct 2, 2019

cc @dadav is this something that we need to keep open for you to track?

@massar
Copy link
Contributor

massar commented Oct 2, 2019

no need to use -S for sparse, as it detects the mode (well, it detects if bmaptool is available).

@benleb
Copy link
Contributor Author

benleb commented Oct 2, 2019

yes and this works like expected 👍 but if there is a -S option in the doc, the tool should recognize it 😅

@massar
Copy link
Contributor

massar commented Oct 2, 2019

Agree, I'll submit a patch to remove it as it is not needed ;)

(and the log shows that it is missing)

@caquino
Copy link
Contributor

caquino commented Oct 3, 2019

We are moving to a new builder where create_sibling will not be needed anymore, and because of that I'm closing this ticket.

Thanks for reporting the issue!

@caquino
Copy link
Contributor

caquino commented Oct 3, 2019

Derek close

@derek derek bot closed this as completed Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants