Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linting and hook up to Travis #22

Closed
4 tasks done
evilsoft opened this issue Jan 10, 2017 · 2 comments
Closed
4 tasks done

Add linting and hook up to Travis #22

evilsoft opened this issue Jan 10, 2017 · 2 comments
Assignees
@evilsoft
Milestone
v0.2.0

Comments

@evilsoft
Copy link
Owner

evilsoft commented Jan 10, 2017 •
edited

No point in having all these tests if we cannot get something to run them for us.
Also because I am so particular about style, my make sense to add some linting, JIC people want to start doing the contrib thang.

  • Add linter (probably eslint)
  • Add npm script for running linter
  • Extend test to run the linter in addition to specs
  • Hook up dat Travis ❤️
@evilsoft evilsoft added this to the v0.2.0 milestone Jan 10, 2017
@evilsoft evilsoft self-assigned this Jan 22, 2017
@evilsoft evilsoft mentioned this issue Jan 22, 2017
Merged
@evilsoft
Copy link
Owner Author

Submitted PR#32 to address this issue.

@evilsoft
Copy link
Owner Author

Merged PR#32.
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evilsoft evilsoft

Labels
None yet
Projects
None yet
Milestone
v0.2.0
Development

No branches or pull requests
1 participant
@evilsoft