Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline support #1252

Open
bwiberg opened this issue Mar 30, 2023 · 3 comments
Open

Offline support #1252

bwiberg opened this issue Mar 30, 2023 · 3 comments

Comments

@bwiberg
Copy link

bwiberg commented Mar 30, 2023

Hi,

First of all, thank you for a great extension.

I work in an offline environment where I do not have internet access. This causes the extension to fail since it relies on the CDN-hosted Font Awesome. I commented out the following lines:

<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/font-awesome/4.5.0/css/font-awesome.min.css">

<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/font-awesome/4.5.0/css/font-awesome.min.css">

And that made the extension work.

Looking through the source code it seems like the MathJax library is loaded from a CDN as well:

mathjax: 'https://cdn.jsdelivr.net/gh/mathjax/mathjax@2.7.8/MathJax.js',

Is this something you're willing to consider adding support for? Two alternatives I can think of are:

  1. Bundling the font-awesome.min.css (and MathJax) files (like you already do with the Remark Javascript code)
  2. Adding an "offline" option to the plugin, causing external resources to be skipped
@evilz
Copy link
Owner

evilz commented Mar 30, 2023

Yes sure !
PR could be nice

@bwiberg
Copy link
Author

bwiberg commented Apr 11, 2023

Which of the two alternatives would you prefer? Bundling everything or adding an offline option?

@evilz
Copy link
Owner

evilz commented Apr 11, 2023

Bundle is nice but is we want to disable some feature. it's not as easy.
So just offline lib to start is enaught I guest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants