Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Implement txpool JSON-RPC namespace #124

Closed
crypto-facs opened this issue Jun 14, 2021 · 1 comment · Fixed by #146
Closed

Implement txpool JSON-RPC namespace #124

crypto-facs opened this issue Jun 14, 2021 · 1 comment · Fixed by #146
Assignees
Labels
C:JSON-RPC JSON-RPC client
Projects

Comments

@crypto-facs
Copy link
Contributor

Proposal: [Description of the feature]
The absence of this method is already documented here but I am creating the request since it is a required method for an open source solution we are using for the future block explorer of the new chain.

Thanks in advance for your time guys, the current transaction fixes are more important as they are blockers on different areas. If maybe this and/or the development of the other missing methods is something we could be of help (the crypto.org team) please let us know.

Current behavior: [What currently happens]
Non existent

Desired behavior: [What you would like to happen]
The expected behavior of this method is documente here.

Use case: [Why is this important (helps with prioritizing requests)]
This is currently important as third party solutions we are using for the development of the chain eco system expect it. It is currently a blocker for the block explorer development.

Requests may be closed if we're not actively planning to work on them.

@fedekunze fedekunze changed the title txpool_content JSON-RPC method Implement txpool JSON-RPC namespace Jun 14, 2021
@fedekunze fedekunze added this to Triage in Core via automation Jun 14, 2021
@fedekunze fedekunze added the C:JSON-RPC JSON-RPC client label Jun 14, 2021
@crypto-facs crypto-facs self-assigned this Jun 15, 2021
@fedekunze fedekunze moved this from Triage to Backlog in Core Jun 15, 2021
@crypto-facs
Copy link
Contributor Author

Will summarize offline discussions about this issue. Given that the concept of pending transactions works different in Tendermint than Ethereum (more info here), there have been discussions about what the appropriate behavior of this endpoint should be. Two options where discussed:

  • Query the mempool of the node and return pending transactions specific to the node. In Tendermint, mempool are node specific pending transactions before every commit, as it offers instant finality (more info here).
  • Return an empty response to avoid misleading information for now until a better solution is designed

For now, the decision was to go with the second option to unblock the integration of third party components of the chain ecosystem that require this endpoint to exist.

Core automation moved this from Backlog to Done Jun 21, 2021
@khoslaventures khoslaventures added this to the Milestone 1: Developer Usability and Testing milestone Jun 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C:JSON-RPC JSON-RPC client
Projects
No open projects
Core
Done
Development

Successfully merging a pull request may close this issue.

3 participants