Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

RPC: Return proper returnValue on default trace response in traceTx #529

Closed
crypto-facs opened this issue Sep 4, 2021 · 2 comments · Fixed by #962
Closed

RPC: Return proper returnValue on default trace response in traceTx #529

crypto-facs opened this issue Sep 4, 2021 · 2 comments · Fixed by #962
Labels
C:JSON-RPC JSON-RPC client good first issue Good for newcomers help wanted Extra attention is needed pinned Pinned issues that won't be closed by stalebot
Projects
pending issues

Comments

@crypto-facs
Copy link
Contributor

Currently returnValue is hardcoded to an empty string on when using the default tracer for debug_traceTransaction.

This will require some methods on MsgEthereumTxResponse to replicate the behavior on Go Ethereum
@github-actions
Copy link

This issue is stale because it has been open 45 days with no activity. Remove Status: Stale label or comment or this will be closed in 7 days.

@tomtau tomtau added C:JSON-RPC JSON-RPC client good first issue Good for newcomers help wanted Extra attention is needed and removed Status: Stale labels Oct 27, 2021
@tomtau tomtau added this to To Do in pending issues Oct 27, 2021
@github-actions
Copy link

This issue is stale because it has been open 45 days with no activity. Remove Status: Stale label or comment or this will be closed in 7 days.

pending issues automation moved this from To Do to Done Dec 20, 2021
@fedekunze fedekunze added pinned Pinned issues that won't be closed by stalebot and removed Status: Stale labels Dec 20, 2021
@fedekunze fedekunze reopened this Dec 20, 2021
@fedekunze fedekunze moved this from Done to To Do in pending issues Dec 20, 2021
@crypto-facs crypto-facs mentioned this issue Feb 28, 2022
Merged
11 tasks
pending issues automation moved this from To Do to Done Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
C:JSON-RPC JSON-RPC client good first issue Good for newcomers help wanted Extra attention is needed pinned Pinned issues that won't be closed by stalebot
Projects
No open projects
pending issues
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add returnValue message on tracing crypto-facs/ethermint
3 participants
@tomtau @fedekunze @crypto-facs